Skip to content

Enhance TokenTextSplitter with flexible punctuation detection, bug fixes, and validation #2526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
qnnn wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Enhance TokenTextSplitter with flexible punctuation detection, bug fixes, and validation #2526

qnnn wants to merge 1 commit into from

Conversation

@qnnn
Copy link

@qnnn qnnn commented Mar 20, 2025

Improves TokenTextSplitter with the following changes:

  • Extends findLastPeriodOrPunctuation to support customizable punctuation detection.
  • Ensures the doSplit method respects maxNumChunks limits and avoids premature processing of remaining tokens.
  • Aligns the default values of TokenTextSplitter$Builder with the direct constructor to avoid inconsistency.
  • Adds input validation for parameters.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

ETL

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@qnnn @markpollack